UITableView indexPath changing while scrolling

Question

In my Table View I have the label text set to a different colour if the name is in the Flagged Array (flaggedNames). The correct cell labels turn red but as I scroll the text of other labels are also red. This changes as I scroll.


    override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {

        let cell = tableView.dequeueReusableCell(withIdentifier: "cell", for: indexPath)

        let name = names[indexPath.row]

        cell.textLabel?.text = name


        if flaggedNames.contains(meterNumber) {

            cell.textLabel?.textColor = .systemRed

        }

        return cell

    }

Swift
UIKit

273

Posted by

Junaid6305

Reply

You are using meterNumber which is not defined in your shown code. Usually, having other variables than data source can easily cause issues as you describe. Also, you are setting textColor to .systemRed, but there is no code which changes textColor to the normal color, please do not forget that cells are reused, the textColor of the cell dequeued is not known. Anyway, to find how to fix, you may need to show more context.

—
OOPer
Sorry that was a typo in my question. “meterNumber” is supposed to be “name”

—
Junaid6305

Add a Comment

Answer 1

Cells can be reused, which can lead to such problems. To this end, you should specify the text color of the normal label in the 'else' statement.

if flaggedNames.contains(meterNumber) {
    cell.textLabel?.textColor = .systemRed
} else { 
    cell.textLabel?.textColor = .black
}

Posted by

minnit

Add a Comment

Answer 2

Cells can be reused, which can lead to such problems. To this end, you should specify the text color of the normal label in the 'else' statement.

if flaggedNames.contains(meterNumber) {
    cell.textLabel?.textColor = .systemRed
} else { 
    cell.textLabel?.textColor = .black
}

Posted by

minnit

Add a Comment

UITableView indexPath changing while scrolling

Accepted Reply

Replies