Problem With Filter

Code Block 
return player.yahooName!.lowercased().contains(searchText.lowercased()) && player.position == "C" && player.position == "RW" && player.position == "LW"

Code Block 
         return player.yahooName!.lowercased().contains(searchText.lowercased()) && (player.position == "C" || player.position == "RW" || player.position == "LW")

Can you show all the definitions of cPlayerArr, allTextArr, fetchAllPlayers(), fetchForwards(), fetchDefense(), fetchGoalies() and all the dataSource methods?
They may not be implemented consistently.

Code Block 
var cPlayerArr = [CurrentPlayers]()
   
//filters players based on scope
var allTextArr = [CurrentPlayers]()
func fetchForwards() {
    do {
      let request = CurrentPlayers.fetchRequest() as NSFetchRequest<CurrentPlayers>
      let forwards = NSPredicate(format: "position CONTAINS 'RW' OR position CONTAINS 'LW' OR position CONTAINS 'C'")
      request.predicate = forwards
      self.allTextArr = try context.fetch(request)
      DispatchQueue.main.async {
        self.collections.reloadData()
      }
    }
    catch {
       
    }
  }
   
  func fetchDefense() {
    do {
      let request = CurrentPlayers.fetchRequest() as NSFetchRequest<CurrentPlayers>
      let defense = NSPredicate(format: "position CONTAINS 'D'")
      request.predicate = defense
      self.allTextArr = try context.fetch(request)
      DispatchQueue.main.async {
        self.collections.reloadData()
      }
    }
    catch {
       
    }
  }
   
  func fetchGoalies() {
    do {
      let request = CurrentPlayers.fetchRequest() as NSFetchRequest<CurrentPlayers>
      let goalies = NSPredicate(format: "position CONTAINS 'G'")
      request.predicate = goalies
      self.allTextArr = try context.fetch(request)
      DispatchQueue.main.async {
        self.collections.reloadData()
      }
    }
    catch {
       
    }
  }
     func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell {
        let cell = collectionView.dequeueReusableCell(withReuseIdentifier: "colcell", for: indexPath) as! PlayerColCell
      if (searchBar.text != "" || searchBar.selectedScopeButtonIndex > 0) {
        item = allTextArr[indexPath.row]
        cell.layer.borderColor = UIColor.black.cgColor
        cell.layer.borderWidth = 0.5
        cell.contentView.backgroundColor = UIColor(red: 102/256, green: 255/256, blue: 255/256, alpha: 0.6)
        cell.update(with: item)
        return cell
      } else {
        item = cPlayerArr[indexPath.row]
        cell.layer.borderColor = UIColor.black.cgColor
        cell.layer.borderWidth = 0.5
        cell.contentView.backgroundColor = UIColor(red: 102/256, green: 255/256, blue: 255/256, alpha: 0.6)
        cell.update(with: item)
        return cell
      }
    }

Thanks Claude. I solved my filtering with the other scopes

but the thing that lingers is I can't delete all the characters in the searchBar unless it's on scope 0 and once I delete characters I can't switch to any scope unless it's scope 0. 

• You need to re-fetch when selectedScopeButtonIndex is changed

• You need to re-filter when searchText is changed

Code Block 
    
    // Array of fetched `CurrentPlayers` when `selectedScopeButtonIndex > 0`
    var origPlayerArr = [CurrentPlayers]()
    func searchBar(_ searchBar: UISearchBar, textDidChange searchText: String) {
        updateFilteredArray(searchText: searchText)
        collections.reloadData()
    }
    
    private func updateFilteredArray(searchText: String) {
        let origArray: [CurrentPlayers]
        if searchBar.selectedScopeButtonIndex > 0 {
            origArray = origPlayerArr
        } else {
            origArray = cPlayerArr
        }
        allTextArr = origArray.filter { player -> Bool in
            if searchText.isEmpty {
                return true
            } else {
                return
                    player.yahooName!.lowercased().contains(searchText.lowercased())
            }
        }
    }
    
    func searchBar(_ searchBar: UISearchBar, selectedScopeButtonIndexDidChange: Int) {
        if (searchBar.selectedScopeButtonIndex == 0) {
            cPlayerArr.removeAll()
            allTextArr.removeAll()
            fetchAllPlayers()
        } else if (searchBar.selectedScopeButtonIndex == 1) {
            allTextArr.removeAll()
            fetchForwards()
        } else if (searchBar.selectedScopeButtonIndex == 2) {
            allTextArr.removeAll()
            fetchDefense()
        } else {
            allTextArr.removeAll()
            fetchGoalies()
        }
        updateFilteredArray(searchText: searchBar.text ?? "")
        collections.reloadData()
    }

Code Block 
    func fetchForwards() {
        do {
            let request = CurrentPlayers.fetchRequest() as NSFetchRequest<CurrentPlayers>
            let forwards = NSPredicate(format: "position CONTAINS 'RW' OR position CONTAINS 'LW' OR position CONTAINS 'C'")
            request.predicate = forwards
            self.origPlayerArr = try context.fetch(request) //<-
        } catch {
            print(error)
            //...
        }
    }
    // Same for `fetchDefense()` and `fetchGoalies()`...

What happens when you delete all char in search bar ? 
Can you delete all but the last ?

One difference I see, is that in case 0 you clear the allTextArr array (what a bizarre name for [CurrentPlayers] array) and you reload them in other cases.

Could you show the code of:
fetchAllPlayers()

Code Block 
   func fetchAllPlayers() {
    parseJSON {
      self.collections.reloadData()
    }
  }

Thanks for showing your code.

Checking your dataSource methods, your UICollectionView (collections) shows allTextArr when searchBar.selectedScopeButtonIndex > 0.
But in your searchBar(_:textDidChange:), you update allTextArr from cPlayerArr.

Generally:
You need to re-fetch when selectedScopeButtonIndex is changed
You need to re-filter when searchText is changed
But your current searchBar(_:textDidChange:) mixes up two different things -- re-fetch and re-filter.

I would write them as follows:

1. When I filter for a specific player in selectedScope > 0, I see multiple cells of the same player instead of one.

2. When I delete all character it should clear and reload one of those fetch methods instead of giving multiple cells of the same player.

3. After I delete all characters and when I try to start typing again in the searchBar I see no cells shown.

Okay I tried your solution but there are issues with selectedScope > 0,

I cannot reproduce the issue you have described. You may be doing something wrong somewhere.

I copied it exactly how it was written and it does fix a few things while giving me a few more issues.

You may be doing something strange beyond my guess where you have not shown yet.

Isn't it let defense = NSPredicate(format: "position CONTAINS [D]")

Okay I will look at my code again, I will recopy it.

there are issues with selectedScope > 0,

1. When I filter for a specific player in selectedScope > 0, I see multiple cells of the same player instead of one.

2. When I delete all character it should clear and reload one of those fetch methods instead of giving multiple cells of the same player.

3. After I delete all characters and when I try to start typing again in the searchBar I see no cells shown.

Code Block 
 func updateFilteredArray(searchText: String) {
   let filterArray: [CurrentPlayers]
   if searchBar.selectedScopeButtonIndex > 0 {
     filterArray = filteredArr
   } else {
     filterArray = cPlayerArr
   }
   filteredArr = filterArray.filter { player -> Bool in
     if searchText.isEmpty {
       return true
     } else {
       print(filteredArray.count)
       return
         player.yahooName!.lowercased().contains(searchText.lowercased())
     }
   }
 }

Code Block 
   func collectionView(_ collectionView: UICollectionView, numberOfItemsInSection section: Int) -> Int {
    let noDArr = Array(Set(filteredArr))
    if (searchBar.text != "" || searchBar.selectedScopeButtonIndex > 0) {
      return noDArr.count 
    } else {
      return cPlayerArr.count
    }
  }