iPad attempting to import Journaling Suggestions

You need to weak link to the framework. To do this:

1. In your app’s target editor, switch to the General tab and add the Journaling Suggestions framework to the Frameworks, Libraries, and Embedded Content list.

2. Switch to the Build Phases tab and, in the Link Binary with Libraries phase, switch the Status popup to Optional.

This shouldn’t be this painful, and we have a bug on file about that (r. 121326851).

Share and Enjoy
—
Quinn “The Eskimo!” @ Developer Technical Support @ Apple
let myEmail = "eskimo" + "1" + "@" + "apple.com"

(I had some weird UI issue in the forums when adding this before, so I might be duplicating this reply).

Thank you, Quinn! That fixed my crash. Lastly, I will still need to somehow differentiate between iPhone and iPad to hide UI. Is the UIDevice idiom still the recommended approach for that? (I'm shaking off the rust after several years of not developing for Apple platforms).

Also, would it be helpful to add any of these details to new radar or would that be unnecessarily duplicating the one you posted?

Appreciate your help.

This did not fix it for me. I did all of this. Now I can't even build on simulator.

As an update to @eskimo 's response,

There's a few cases here:

• Case #1: Building for the simulator.
• Case #2: Building for a real device, but running on a device where the framework isn't present (eg: iPad, Mac)
• Case #3: Building for an iOS version before iOS 17.2 where the framework isn't available

For case #1: use #if canImport(JournalingSuggestions) like this:

#if canImport(JournalingSuggestions)
    import JournalingSuggestions
#endif

Then, in your code where you use JournalingSuggestionsPicker, check if you can import it first. This way, if you're not building for a real device, the framework will not be imported.

For case #2: Since you're building for a real device, the framework can be imported. Since it's not an iPhone, your app will crash when run. Protect against this by first checking if you can import UIKit, then setting isJournalingSuggestionsAvailable to be true if you're on an iPhone. If you're on Mac, where UIKit can't be imported, isJournalingSuggestionsAvailable will be false anyways. For example:

#if canImport(UIKit)
import UIKit
let isJournalingSuggestionsAvailable = UIDevice.current.userInterfaceIdiom == .phone
#else
let isJournalingSuggestionsAvailable = false
#endif

In your code, where you use JournalingSuggestionsPicker, first check if you can import it with the info in case #1 above, then check if isJournalingSuggestionsAvailable is true.

For case #3: To handle the older iOS case, you need if #available(iOS 17.2, *)

Altogether, it looks like this in code:

#if canImport(JournalingSuggestions)
    if isJournalingSuggestionsAvailable {
        if #available(iOS 17.2, *) {
            JournalingSuggestionsPicker {
                Text("Choose a suggestion")
            } onCompletion: { suggestion in
                print("suggestion:", suggestion)
            }
        } else {
            Text("Requires iOS 17.2.")
        }
    } else {
        Text("Dynamically not available on this platform.")
    }
#else
    Text("Statically not available on this platform.")
#endif
}

Important - iPad weak linking

To ensure your app can run on iPad without crashing, you must weak link to the framework. The normal way to do this is via the Status column in the Link Binary With Libraries build phase. That doesn’t work here because the framework isn’t available on the iOS Simulator platform, so the simulator build fails, as @bryan1anderson pointed out. The workaround is to pass in -Xlinker -weak_framework -Xlinker JournalingSuggestions via the Other Linker Flags build setting.

This did not fix it @sha921 @eskimo

#if canImport(JournalingSuggestions) just does not work. The code inside of it always runs. It doesn't matter if I mark the framework as optional in build phases. I doesn't matter if I provide the manual linker flag.

Anything inside #if canImport(JournalingSuggestions) still executes on iPads.

This is BEYOND problematic because it doesn't MATTER if I use the device idiom to check if it's on an iPad or a phone. Because SwiftUI runs that code no matter what. The binary will always crash because #if canImport(JournalingSuggestions) does not block execution.

And besides, the linker flags solution DID NOT fix the simulator issue. Same exact issue. This is a massive problem.

#if canImport(JournalingSuggestions)

                                if true == false {
                                    //OBVIOUSLY this case will never "run" but SwiftUI still checks it, and therefore crashes the app
                                    //THIS STILL CAUSES A CRASH ON IPAD, if I want it to run i need to comment out.
                                    JournalingSuggestionsPicker {
                                                   Text("Choose a suggestion")
                                               } onCompletion: { suggestion in
                                                   print("suggestion:", suggestion)
                                               }
                                } else {
                                    //Only getting here if I comment out JournalingSuggestions code cause CRASH
                                    Text("Would see this on iPad if I used the device idiom check instead of true == false")
                                }
#else
        Text("Only see this on simulator, when I don't link weakly, otherwise i cannot build to simulator no matter what")
#endif

This did not fix it

You have to conditionalise the Other Linker Flags build setting based on whether you’re building for the simulator or not. Here’s what that looks like in Xcode:

#if canImport(JournalingSuggestions) just does not work.

You need all three checks here:

• #if canImport(JournalingSuggestions)

• if isJournalingSuggestionsAvailable

• if #available(iOS 17.2, *)

Try using the code that sha921 posted.

This is a massive problem.

You’ll get no argument from me on that front! As I mentioned earlier, we have a bug on file requesting improvements in this space (r. 121326851).

Share and Enjoy
—
Quinn “The Eskimo!” @ Developer Technical Support @ Apple
let myEmail = "eskimo" + "1" + "@" + "apple.com"

same with me, all provided solutions do not work

Failed to look up symbolic reference at 0x10460f095 - offset 3979 - symbol symbolic _____y_____y_____yACy__________y_____GG_____y_____GG___________y_____yAMGAMGtGG 7SwiftUI6VStackV AA9TupleViewV AA15ModifiedContentV AA5ImageV AA30_EnvironmentKeyWritingModifierV AI5ScaleO AA016_ForegroundStyleL0V AA09TintShapeO0V AA4TextV AA012_ConditionalG0V 21JournalingSuggestions0tU6PickerV in /private/var/folders/dg/m7p8ljs52vv5phhm44r9bb7h0000gn/X/92886C6C-BD41-5654-A4AC-0B95A4D04BC7/d/Wrapper/JournalingSuggestionsCrash1.app/JournalingSuggestionsCrash1.debug.dylib

I was able to narrow it down to ViewBuilders. Here is a sample project. I'm able to fix this by wrapping this inside a non view builder type erased view.

MESSY

This won't let me upload the zip file..

import SwiftUI
#if canImport(JournalingSuggestions)
import JournalingSuggestions
#endif

struct ContentView: View {
    
    var willNotCrash: AnyView {
#if canImport(JournalingSuggestions)
            if true == false {
                //should never run, but still crashes
                return AnyView(JournalingSuggestionsPicker("Picker") { suggestion in
                    
                })
            } else {
                return AnyView(Text("Should always show"))
            }
#else
            return AnyView(Text("Should show on ipad"))
#endif

    }
    
    @ViewBuilder var willCrash: some View {
#if canImport(JournalingSuggestions)
        if true == false {
            JournalingSuggestionsPicker("Picker") { suggestion in
                
            }
        } else {
            Text("Should always show")    
        }
#else
        Text("Should show on ipad")
#endif

    }
    
    var body: some View {
        VStack {
            
//            willCrash
            
            willNotCrash
        }
        .padding()
    }
}

Hi @bryan1anderson and @aleksandr_kulaga ,

Here's steps to conditionalize this correctly in your build settings:

1. Open build settings for your Xcode project's target
2. Make sure "All" and "Levels" are selected at the top
3. Search for "Other linker flags" in the search bar
4. Expand the "Other linker flags" settings
5. For "Debug", add a condition for "iOS" by pressing the "plus" button to the right of the word.
6. Do the same for "Release"

• both "Debug" and "Release" should now be expanded with "Any iOS SDK" as the conditional for each

1. In the empty box under your app's name on the right of the "Any iOS SDK" for "Debug" setting, double click to open the add/remove box.
2. Press the plus button, and add the following four statements on their own lines. You will then have four entries

-Xlinker

weak_framework

-Xlinker

JournalingSuggestions

1. Now do the exact same thing for the box at the right of the "Any iOS SDK" for "Release setting"

Your ContentView should look like this:

//
//  ContentView.swift

import SwiftUI
#if canImport(JournalingSuggestions)
    import JournalingSuggestions
#endif

#if canImport(UIKit)
    import UIKit
    let isJournalingSuggestionsAvailable = UIDevice.current.userInterfaceIdiom == .phone
#else
    let isJournalingSuggestionsAvailable = false
#endif


struct ContentView: View {
    var body: some View {
        VStack {
#if canImport(JournalingSuggestions)
    if isJournalingSuggestionsAvailable {
        if #available(iOS 17.2, *) {
            JournalingSuggestionsPicker {
                Text("Open suggestions")
            } onCompletion: { suggestion in
                print("suggestion:", suggestion)
            }
        } else {
            Text("Requires iOS 17.2.")
        }
    } else {
        Text("Dynamically not available on this platform.")
    }
#else
    Text("Statically not available on this platform.")
#endif
}
        .padding()
    }
}

Try running your app in the simulator on an iPhone and it will work.

Nah that doesn't fix it